Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update format API #228

Merged
merged 10 commits into from
Jun 6, 2018
Merged

update format API #228

merged 10 commits into from
Jun 6, 2018

Conversation

iamkun
Copy link
Owner

@iamkun iamkun commented Jun 6, 2018

No description provided.

iamkun
iamkun commented Jun 6, 2018
View reviewed changes
src/locale/th.js
@@ -3,7 +3,7 @@ import dayjs from 'dayjs'
const locale = {
name: 'th',
weekdays: 'อาทิตย์_จันทร์_อังคาร_พุธ_พฤหัสบดี_ศุกร์_เสาร์'.split('_'),
weekdaysShort: 'อา._จ._อ._พ._พฤ._ศ._ส.'.split('_'),
weekdaysShort: 'อาทิตย์_จันทร์_อังคาร_พุธ_พฤหัส_ศุกร์_เสาร์'.split('_'),
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saknarak
In order to pass the unit test compared to moment.js, I've changed this locale a little bit. Is this still OK in thai?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it still OK in Thai.

// from moment.js
        weekdaysShort : 'อาทิตย์_จันทร์_อังคาร_พุธ_พฤหัส_ศุกร์_เสาร์'.split('_'),
        weekdaysMin : 'อา._จ._อ._พ._พฤ._ศ._ส.'.split('_'),

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @saknarak , just wondering if we should add weekdaysMin as well?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, moment use
d => this.$W
dd => weekdaysMin
ddd => weekdaysShort
dddd => weekdays

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great.

@codecov-io
Copy link

codecov-io commented Jun 6, 2018 •
edited
Loading

Codecov Report

Merging #228 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #228   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          23     24    +1     
  Lines         338    344    +6     
  Branches       52     51    -1     
=====================================
+ Hits          338    344    +6
Impacted Files Coverage Δ
src/locale/zh-cn.js 100% <ø> (ø) ⬆️
src/locale/th.js 100% <ø> (ø) ⬆️
src/index.js 100% <100%> (ø) ⬆️
src/plugin/isLeapYear/index.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c223371...d37f456. Read the comment docs.

@iamkun iamkun merged commit 5ca48f0 into master Jun 6, 2018
iamkun pushed a commit that referenced this pull request Jun 6, 2018
@semantic-release-bot
chore(release): 1.6.6 [skip ci]
73495cb 
<a name="1.6.6"></a>
## [1.6.6](v1.6.5...v1.6.6) (2018-06-06)

### Bug Fixes

*  format API update and locale file update ([5ca48f0](5ca48f0)), closes [#228](#228)
@iamkun
Copy link
Owner Author

iamkun commented Jun 6, 2018

🎉 This PR is included in version 1.6.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
@andrewhood125ruhuc
chore(release): 1.6.6 [skip ci]
996cb2f 
<a name="1.6.6"></a>
## [1.6.6](iamkun/dayjs@v1.6.5...v1.6.6) (2018-06-06)

### Bug Fixes

*  format API update and locale file update ([5ca48f0](iamkun/dayjs@5ca48f0)), closes [#228](iamkun/dayjs#228)
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
@andrewhood125ruhuc
chore(release): 1.6.6 [skip ci]
10df417 
<a name="1.6.6"></a>
## [1.6.6](iamkun/dayjs@v1.6.5...v1.6.6) (2018-06-06)

### Bug Fixes

*  format API update and locale file update ([5ca48f0](iamkun/dayjs@5ca48f0)), closes [#228](iamkun/dayjs#228)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saknarak saknarak saknarak left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iamkun @codecov-io @saknarak