Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incomplete German locales #1775

Merged
merged 1 commit into from
Feb 28, 2022
Merged

Fix incomplete German locales #1775

merged 1 commit into from
Feb 28, 2022

Conversation

epictecch
Copy link
Contributor

The locale definitions for the German regions Switzerland (de-ch) and Austria (de-at) were incomplete and wrong. This commit makes the definition complete, corrects the error regarding the setting "ordinal" for de-ch and introduces tests which verify the region specific identifiers.

@codecov
Copy link

codecov bot commented Feb 3, 2022

Codecov Report

Merging #1775 (d67c61b) into dev (4a7b7d0) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #1775   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          179       179           
  Lines         1996      2008   +12     
  Branches       507       511    +4     
=========================================
+ Hits          1996      2008   +12     
Impacted Files Coverage Δ
src/locale/de-at.js 100.00% <100.00%> (ø)
src/locale/de-ch.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a7b7d0...d67c61b. Read the comment docs.

@iamkun iamkun merged commit f9055a7 into iamkun:dev Feb 28, 2022
@epictecch epictecch deleted the fix/german-locales branch February 28, 2022 15:44
iamkun pushed a commit that referenced this pull request Mar 14, 2022
# [1.11.0](v1.10.8...v1.11.0) (2022-03-14)

### Bug Fixes

* Add Kirundi (rn) locale ([#1793](#1793)) ([74e5247](74e5247))
* add missing date shorthand D type definition ([#1752](#1752)) ([b045baf](b045baf))
* Add relative time to Galician (gl) and fix ordinals ([#1800](#1800)) ([dcbf170](dcbf170))
* update German locales (de-at, de-ch) ([#1775](#1775)) ([f9055a7](f9055a7))
* update Icelandic [is] locale relativeTime config ([#1796](#1796)) ([76f9e17](76f9e17))
* Update index.d.ts note ([#1716](#1716)) ([5a108ff](5a108ff))
* Update locale German [de] monthsShort ([#1746](#1746)) ([4a7b7d0](4a7b7d0))
* update meridiem function to Kurdish (ku) locale ([#1725](#1725)) ([efd3904](efd3904))
* update updateLocal plugin typescript types ([#1692](#1692)) ([c7a3f73](c7a3f73))

### Features

* Fallback to language only locale + support uppercase locales ([#1524](#1524)) ([9138dc2](9138dc2))
@iamkun
Copy link
Owner

iamkun commented Mar 14, 2022

🎉 This PR is included in version 1.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
# [1.11.0](iamkun/dayjs@v1.10.8...v1.11.0) (2022-03-14)

### Bug Fixes

* Add Kirundi (rn) locale ([#1793](iamkun/dayjs#1793)) ([74e5247](iamkun/dayjs@74e5247))
* add missing date shorthand D type definition ([#1752](iamkun/dayjs#1752)) ([b045baf](iamkun/dayjs@b045baf))
* Add relative time to Galician (gl) and fix ordinals ([#1800](iamkun/dayjs#1800)) ([dcbf170](iamkun/dayjs@dcbf170))
* update German locales (de-at, de-ch) ([#1775](iamkun/dayjs#1775)) ([f9055a7](iamkun/dayjs@f9055a7))
* update Icelandic [is] locale relativeTime config ([#1796](iamkun/dayjs#1796)) ([76f9e17](iamkun/dayjs@76f9e17))
* Update index.d.ts note ([#1716](iamkun/dayjs#1716)) ([5a108ff](iamkun/dayjs@5a108ff))
* Update locale German [de] monthsShort ([#1746](iamkun/dayjs#1746)) ([4a7b7d0](iamkun/dayjs@4a7b7d0))
* update meridiem function to Kurdish (ku) locale ([#1725](iamkun/dayjs#1725)) ([efd3904](iamkun/dayjs@efd3904))
* update updateLocal plugin typescript types ([#1692](iamkun/dayjs#1692)) ([c7a3f73](iamkun/dayjs@c7a3f73))

### Features

* Fallback to language only locale + support uppercase locales ([#1524](iamkun/dayjs#1524)) ([9138dc2](iamkun/dayjs@9138dc2))
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
# [1.11.0](iamkun/dayjs@v1.10.8...v1.11.0) (2022-03-14)

### Bug Fixes

* Add Kirundi (rn) locale ([#1793](iamkun/dayjs#1793)) ([74e5247](iamkun/dayjs@74e5247))
* add missing date shorthand D type definition ([#1752](iamkun/dayjs#1752)) ([b045baf](iamkun/dayjs@b045baf))
* Add relative time to Galician (gl) and fix ordinals ([#1800](iamkun/dayjs#1800)) ([dcbf170](iamkun/dayjs@dcbf170))
* update German locales (de-at, de-ch) ([#1775](iamkun/dayjs#1775)) ([f9055a7](iamkun/dayjs@f9055a7))
* update Icelandic [is] locale relativeTime config ([#1796](iamkun/dayjs#1796)) ([76f9e17](iamkun/dayjs@76f9e17))
* Update index.d.ts note ([#1716](iamkun/dayjs#1716)) ([5a108ff](iamkun/dayjs@5a108ff))
* Update locale German [de] monthsShort ([#1746](iamkun/dayjs#1746)) ([4a7b7d0](iamkun/dayjs@4a7b7d0))
* update meridiem function to Kurdish (ku) locale ([#1725](iamkun/dayjs#1725)) ([efd3904](iamkun/dayjs@efd3904))
* update updateLocal plugin typescript types ([#1692](iamkun/dayjs#1692)) ([c7a3f73](iamkun/dayjs@c7a3f73))

### Features

* Fallback to language only locale + support uppercase locales ([#1524](iamkun/dayjs#1524)) ([9138dc2](iamkun/dayjs@9138dc2))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants