-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.9.2 crashes with "TypeError: t is not a function" #1132
Comments
same here can you please rollback the last version? |
Will check this ASAP |
v1.9.3 has fixed this bug. Sorry for the inconvenience. |
🎉 This issue has been resolved in version 1.9.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Thanks for the quick fix @iamkun, appreciated. |
Great thanks @iamkun for fast response! Do you plan to improve a release flow to avoid such issues in a feature? e.g. by building in CI, verifying the build and only after that passes releasing a new version in context of a CI? |
@medikoo sure. All of the release work is made by CI in an auto workflow atm. Just wondering if we should make a test build in each PR to avoid this. |
I believe there should be test build prior npm publish it's what would prevent broken release |
This is just a rollup warning, that's why it did not stop the release. |
Having this issue when running jest tests:
UPD: |
I use rescript which compiles to js. It compiles imports like this: As a result, my component using dayjs is untestable. When will a fix be put in that will allow me to import it using the *? Thanks! |
## [1.9.3](iamkun/dayjs@v1.9.2...v1.9.3) (2020-10-13) ### Bug Fixes * fix localizedFormat export error ([#1133](iamkun/dayjs#1133)) ([deecd6a](iamkun/dayjs@deecd6a)), closes [#1132](iamkun/dayjs#1132)
## [1.9.3](iamkun/dayjs@v1.9.2...v1.9.3) (2020-10-13) ### Bug Fixes * fix localizedFormat export error ([#1133](iamkun/dayjs#1133)) ([deecd6a](iamkun/dayjs@deecd6a)), closes [#1132](iamkun/dayjs#1132)
I have the same error in version 1.11.7 |
Are you importing like this?
or like this?
The first causes the error for me on 1.11.10, the second doesn't. |
I think I encounter the same error:
For me it's on 1.11.13 on vite + typescript. And I saw here that there's a specific guide for this but it doesn't seem to work, i.e:
In my tsconfig and yet...
doesn't work
works |
Describe the bug
I've just upgraded from v1.9.1 to v1.9.2 (just released) and following started to crash
Error:
Expected behavior
No error should happen
Information
The text was updated successfully, but these errors were encountered: