-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add power limits #6929
Add power limits #6929
Conversation
4665134
to
2f61d79
Compare
2f61d79
to
8fbf14e
Compare
This would be great for flying with li-ion packs. I vaguely remember there was a feature request for this but I cannot find it anymore. Quick question though, are the time limits set in deciseconds? I don't think that time unit is used anywhere else in INAV so maybe it's better to change it so either seconds or milliseconds. Also, a max burst time of 60 seconds could be useful depending on how you set the constant and burst currents/powers. |
I vaguely remember a similar request but I can't find it either
Yes deciseconds. TBH I would much prefer having the settings be seconds but I also like the tenth of a second granularity. The best would be to switch to float but that would double the storage size for the timing settings from 8 bytes to 16 bytes, I am not sure it is worth it. |
Hmm yeah, perhaps this should be made more intuitive on the configurator side at some point (but not only for this feature, iNavFlight/inav-configurator#1201). Can you increase the max value for |
I wanted to add these settings to the GUI but I wanted to use the generic settings interface and there is an issue with that in the configuration tab. I'm not sure what is going on.
Let's make it even 300s |
56566ce
to
821f360
Compare
Hi @shellixyz , I aim at using a li ion battery on my 5"quad to do some longer time flight (smooth flight not freestyle), but I would like to keep quad motor configuration as it is to be able to switch from long flight to freestyle (shorter flight) mode. If I understand this PR, it is the solution to limit power. I would like to test it on my lipo first to see if it will be still flyable with limits for li ion. Do you know which kind of parameters I have to set in the Cli to tune this? Arnotlse |
I will add documentation for this soon. There are 4 parameters you can set to change the behavior:
You can find all the settings and their description in the documentation. Settings for power limitation begins with |
Hi @shellixyz, Ok, thanks a lot. Arno |
Hi @shellixyz, Another question, does it works also with battery profile? I mean, can I limit the current using the parameter you mention depending on the battery profile used? For example, if I want to limit current with specific values to use li ion battery safely (30A max) when selecting battery profile n°2 and go back to default value for battery profile n°1, is it manageable? Or are the variables for current limitation unique and apply to all battery profile? Arno |
Not in 3.0 but that will be possible in 3.1 |
OK, great. Thanks for the information. Arno |
Hi @shellixyz, I have made a flight yesterday with such limit configured :
I have made some vertical acceleration test (gently accelerating) to see if the limitations will be floored by those settings. I have experimented at moment, a very short déstabilisation of the quad following quickly by a complete shutoff of the quad in flight when pushing throttle. When I get it back, I have to disconnect and reconnect the lipos to make it work again. Disam/arm not working. Unfortunately, the log is corrupted. It has stopped recording before this event. So it is just what I have observed. Do you know if it is a normal or expected behavior? Do I have also to configure limit_power stuff related to limit_current? Arno |
Adds the possibility to limit the throttle depending on set current/power continuous/burst values
Matching configurator part: iNavFlight/inav-configurator#1259
Closes #3888