Increase max cell count to 12 #6794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@avsaase Can I get you to take a look at the way this interacts with Thanks |
|
@rts18 Does it show the correct cell count in the configurator? I decreased the default dell detect voltage to 4.25V (from 4.30V) to make it less likely to detect an empty battery as a full one with a lower cell count. This didn't cause problems for me but you could try setting it back to 4.3V. |
|
Shit, you're right. For all my 2-4S batteries it detects one more cell than they have, so it never thinks the batteries are full. |
Merged
|
Great work 👍 Thanks for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.