Refactor SBUS handling code (potential race condition fixed) #3110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l handling of SBUS2 data if necessary
fiam
approved these changes
Apr 26, 2018
src/main/rx/sbus_channels.c
Outdated
| if (channels->flags & SBUS_FLAG_FAILSAFE_ACTIVE) { | ||
| // internal failsafe enabled and rx failsafe flag set | ||
| // RX *should* still be sending valid channel data, so use it. | ||
| return RX_FRAME_COMPLETE | RX_FRAME_FAILSAFE; | ||
| } | ||
|
|
||
| return RX_FRAME_COMPLETE; | ||
| else { |
There was a problem hiding this comment.
I'd remove this else since you have a return in the preceding if.
|
Tested on the bench with a non FrSky receiver. Works. |
|
I suppose we can merge it now. I've tested with multiple receivers, all seem to work just fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make S.Bus data updates atomic. Intoroduce better buffer handling (don't wait until timeout to start next frame reception). Could be a fix for #2981