Use string builder when generating binary param #1458
Conversation
antonydenyer
force-pushed
the
master
branch
2 times, most recently
from
160c963 to
94b94d5
Compare
|
@conor10 it will be good to merge and release this work as is currently a blocker for Consensys/quorum-acceptance-tests#123. thank you! |
|
Sure, I'll get one of the team on it. |
|
@antonydenyer @ricardolyn I have done the merge let me know if there is anything that needs to be done here. As a side note, I was curious about the contract size limit in Quorum, it appears to allow 64kb as opposed to Etheruem EIP 170 (24kb)? |
|
@mohamedelshami yes, GoQuorum allows to configure the contract dize limit by using this and this configuration on the genesis file. those values can be configured between 24kb and 128kb. More information on https://docs.goquorum.consensys.net/en/stable/HowTo/Configure/GenesisOptions/#contract-code-size |
|
I updated the version on the plugin: hyperledger-web3j/web3j-maven-plugin#74. could you take a look? thank you |
What does this PR do?
When generating sources with large contracts the binary can go over the 64k string limit.
Switched to use a string builder instead as per square/javapoet#776