This repository has been archived by the owner on Nov 30, 2017. It is now read-only.
enable CLI support for GET_ATTR, GET_SCHEMA, GET_CLAIM_DEF (INDY-23) #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support was already enabled in sovrin node for these so this just adds support to the CLI and corresponding unit tests
|
|
ashcherbakov
suggested changes
Jul 7, 2017
| expect=CLAIM_DEF_FOUND, within=5) | ||
|
|
||
|
|
||
| def test_send_get_schema_as_alice_fails(be, do, poolNodesStarted, trusteeCli, |
There was a problem hiding this comment.
Looks like this is a test for GET_CLAIM_DEF< not GET_SCHEMA. Please fix the name of the test
| expect=CLAIM_DEF_NOT_FOUND, within=5) | ||
|
|
||
|
|
||
| def test_send_get_schema_with_invalid_ref_fails(be, do, poolNodesStarted, |
There was a problem hiding this comment.
Looks like this is a test for GET_CLAIM_DEF< not GET_SCHEMA. Please fix the name of the test
| expect=CLAIM_DEF_NOT_FOUND, within=5) | ||
|
|
||
|
|
||
| def test_send_get_schema_with_invalid_signature_fails(be, do, poolNodesStarted, |
There was a problem hiding this comment.
Looks like this is a test for GET_CLAIM_DEF< not GET_SCHEMA. Please fix the name of the test
| @@ -52,11 +57,23 @@ | |||
| "\s+(?P<keys_key>keys=)\s*(?P<keys>[0-9a-zA-Z-_,\s]+)\s*)".format( | |||
| schema=SovrinTransactions.SCHEMA.name) | |||
|
|
|||
| GET_SCHEMA_REG_EX = "(\s*(?P<send_get_schema>send\s+{getSchema})" \ | |||
There was a problem hiding this comment.
Please add tests to test_command_reg_ex.py
| @@ -41,6 +41,11 @@ | |||
| "\s+ (?P<dest>dest=)\s*(?P<dest_id>[A-Za-z0-9+=/]+) \s*) ".format( | |||
| getNym=SovrinTransactions.GET_NYM.name) | |||
|
|
|||
| GET_ATTR_REG_EX = \ | |||
There was a problem hiding this comment.
Please add tests to test_command_reg_ex.py
| SEND_CLAIM_DEF_REG_EX = "(\s*(?P<send_claim_def>send\s+{issKey})" \ | ||
| "\s+(?P<ref_key>ref=)\s*(?P<ref>[0-9]+)\s*)"\ | ||
| "\s*(?P<signature_type_key>signature_type=)\s*(?P<signature_type>[A-Z0-9]+)" \ | ||
| .format(issKey=SovrinTransactions.CLAIM_DEF.name) | ||
|
|
||
| GET_CLAIM_DEF_REG_EX = "(\s*(?P<send_get_claim_def>send\s+{issKey})" \ |
There was a problem hiding this comment.
Please add tests to test_command_reg_ex.py
ashcherbakov
approved these changes
Jul 7, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support was already enabled in sovrin node for these so this just
adds support to the CLI and corresponding tests