Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NodeJS Deps #403

Merged
merged 1 commit into from
Jan 13, 2021
Merged

Update NodeJS Deps #403

merged 1 commit into from
Jan 13, 2021

Conversation

lindluni
Copy link
Contributor

Signed-off-by: Brett Logan brett.t.logan@ibm.com

@lindluni lindluni requested a review from a team as a code owner January 13, 2021 14:55
Update all of the Node deps to 2.2.<latest>
and regenerate existing package-lock.json files

Signed-off-by: Brett Logan <brett.t.logan@ibm.com>
@nikhil550
Copy link
Contributor

This sample is actually deprecated, and I wondered when it would be removed, since it is no longer pointed to by the docs. I assumed the 2.3 branch?

@lindluni lindluni changed the title Update Fabcar Deps Update NodeJS Deps Jan 13, 2021
@lindluni
Copy link
Contributor Author

This sample is actually deprecated, and I wondered when it would be removed, since it is no longer pointed to by the docs. I assumed the 2.3 branch?

I updated the title, originally I was just updating the fabcar deps, as I noticed they were out of date, but then I noticed everything was out of date, so I updated everything. But that is a good question...

Dave does plan to tag the release-2.2 and v2.2.x this afternoon, maybe thats a good time to remove it afterwards

@lindluni
Copy link
Contributor Author

Also, just for the record should someone wonder why the package-lock files were removed: I did talk to the Node SDK maintainers and confirmed they would like to remove the package-lock files. We had some applications that had it, and some that did not. For now they said lets remove it (since in production you would correctly want to add the lock and properly shrink-wrap the application, which we don't do at all), and if they decide later we can add them all back.

@nikhil550 nikhil550 merged commit 08aaaf0 into hyperledger:master Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants