Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disconnected from the gateway in fabcar query.js #190

Merged
merged 1 commit into from
May 27, 2020

Conversation

pratikspatil024
Copy link
Contributor

After the evaluation of transaction in fabcar -> javascript -> query.js , the gateway was not disconnected.
Hope it helps.

@pratikspatil024 pratikspatil024 requested a review from a team as a code owner May 25, 2020 22:36
Signed-off-by: pratikpatil024 <pratikspatil024@gmail.com>
@pratikspatil024 pratikspatil024 force-pushed the Update_QueryJS_fabcar branch from 7271223 to 3a41be1 Compare May 25, 2020 22:41
Copy link
Contributor

@lehors lehors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution!

@lehors lehors merged commit 2759db2 into hyperledger:master May 27, 2020
xhens added a commit to xhens/fabric-samples that referenced this pull request May 28, 2020
* add miss checksum (hyperledger#168)

Signed-off-by: hello2mao <hello2mao@gmail.com>

* [FAB-17818] Update documetation in Fabric samples repo (hyperledger#170)

Signed-off-by: NIKHIL E GUPTA <negupta@us.ibm.com>

Co-authored-by: NIKHIL E GUPTA <negupta@us.ibm.com>

* FABCAG-27 Update fabric-samples to use latest contract-api-go@v1.1.0

Signed-off-by: heatherlp <heatherpollard0@gmail.com>

* Update user echo text in test network (hyperledger#172)

Clarify config tx generation messages.

Signed-off-by: David Enyeart <enyeart@us.ibm.com>

* Remove docker-compose-e2e file

Signed-off-by: NIKHIL E GUPTA <negupta@us.ibm.com>

* [FAB-17847] Fix some wrong messages in test-network (hyperledger#181)

Signed-off-by: Tatsuya Sato <Tatsuya.Sato@hal.hitachi.com>

* Add CA version argument, CA version does not match fabric version, so it must use another argument (hyperledger#178)

* add ca version argument,fix bug

Signed-off-by: duanmeng <duanmeng@cmss.chinamobile.com>

* codereview fix

Signed-off-by: duanmeng <duanmeng@cmss.chinamobile.com>

* Remove adding current directory to path (hyperledger#184)

Signed-off-by: NIKHIL E GUPTA <negupta@us.ibm.com>

Co-authored-by: NIKHIL E GUPTA <negupta@us.ibm.com>

* Add asset transfer (marbles transfer) sample chaincode

Signed-off-by: NIKHIL E GUPTA <negupta@us.ibm.com>

* Nominate Nikhil Cupta as Fabric-samples maintainer (hyperledger#180)

Nik has been the main source of progress in the fabric-samples
repository for several months, making significant improvements with
the introduction of test-network and updates of all the different
samples around it, among other things.

Signed-off-by: Arnaud J Le Hors <lehors@us.ibm.com>

* fix first network byfn.sh usage (hyperledger#186)

Signed-off-by: zhuzeyu <zhuzeyu0409@gmail.com>

* Add missing Copyright in some files (hyperledger#163)

Signed-off-by: Arnaud J Le Hors <lehors@us.ibm.com>

* Add CHANGELOG.md with script to update it (hyperledger#162)

Signed-off-by: Arnaud J Le Hors <lehors@us.ibm.com>

* FGJ-84 Update Fabcar Java app to 2.1.1 (hyperledger#167)

This updates the fabcar java application to work with the fabric
gateway java version 2.1.1.
It also changes pom.xml to produce a jar file that is self contained
for ease of use.

Signed-off-by: Arnaud J Le Hors <lehors@us.ibm.com>

* Add function to private data hash to sample private data chaincode

Signed-off-by: NIKHIL E GUPTA <negupta@us.ibm.com>

* Update marbles transfer images

Signed-off-by: NIKHIL E GUPTA <negupta@us.ibm.com>

* Add transfer sample to readme (hyperledger#189)

Signed-off-by: NIKHIL E GUPTA <negupta@us.ibm.com>

Co-authored-by: NIKHIL E GUPTA <negupta@us.ibm.com>

* Fix last image in transfer sample

Signed-off-by: NIKHIL E GUPTA <negupta@us.ibm.com>

* Implement sale, bid, and history queries

- Add marbles proposed sale and bid prices queries
- Add marbles history query
- Add verification of ownership when selling marble

Signed-off-by: Tiffany Harris <tiffany.harris@ibm.com>
Signed-off-by: Dereck Luo <dereckluo@gmail.com>

* FAB-17930: Update licenses (hyperledger#191)

Signed-off-by: Ry Jones <ry@linux.com>

* Disconnected from the gateway in fabcar query.js (hyperledger#190)

Signed-off-by: pratikpatil024 <pratikspatil024@gmail.com>

* FABG-935 GoSDK Fabcar sample (hyperledger#192)

Fabcar sample demonstrating the use of the new Gateway package in the Go SDK

Signed-off-by: andrew-coleman <andrew_coleman@uk.ibm.com>

Co-authored-by: Hongbin Mao <hello2mao@gmail.com>
Co-authored-by: nikhil550 <nikhilg550@gmail.com>
Co-authored-by: NIKHIL E GUPTA <negupta@us.ibm.com>
Co-authored-by: heatherlp <heatherpollard0@gmail.com>
Co-authored-by: denyeart <enyeart@us.ibm.com>
Co-authored-by: Tatsuya Sato <Tatsuya.Sato@hal.hitachi.com>
Co-authored-by: duanmeng1992 <duanmeng@cmss.chinamobile.com>
Co-authored-by: Arnaud J Le Hors <lehors@us.ibm.com>
Co-authored-by: Pluto <zhuzeyu0409@gmail.com>
Co-authored-by: Tiffany Harris <tiffany.harris@ibm.com>
Co-authored-by: Ry Jones <ry@linux.com>
Co-authored-by: Pratik Patil <pratikspatil024@gmail.com>
Co-authored-by: Andrew Coleman <andrew_coleman@uk.ibm.com>
xhens added a commit to xhens/fabric-samples that referenced this pull request May 31, 2020
* Implement sale, bid, and history queries

- Add marbles proposed sale and bid prices queries
- Add marbles history query
- Add verification of ownership when selling marble

Signed-off-by: Tiffany Harris <tiffany.harris@ibm.com>
Signed-off-by: Dereck Luo <dereckluo@gmail.com>

* FAB-17930: Update licenses (hyperledger#191)

Signed-off-by: Ry Jones <ry@linux.com>

* Disconnected from the gateway in fabcar query.js (hyperledger#190)

Signed-off-by: pratikpatil024 <pratikspatil024@gmail.com>

* FABG-935 GoSDK Fabcar sample (hyperledger#192)

Fabcar sample demonstrating the use of the new Gateway package in the Go SDK

Signed-off-by: andrew-coleman <andrew_coleman@uk.ibm.com>

Co-authored-by: Tiffany Harris <tiffany.harris@ibm.com>
Co-authored-by: Ry Jones <ry@linux.com>
Co-authored-by: Pratik Patil <pratikspatil024@gmail.com>
Co-authored-by: Andrew Coleman <andrew_coleman@uk.ibm.com>
xhens added a commit to xhens/fabric-samples that referenced this pull request Jun 1, 2020
* Implement sale, bid, and history queries

- Add marbles proposed sale and bid prices queries
- Add marbles history query
- Add verification of ownership when selling marble

Signed-off-by: Tiffany Harris <tiffany.harris@ibm.com>
Signed-off-by: Dereck Luo <dereckluo@gmail.com>

* FAB-17930: Update licenses (hyperledger#191)

Signed-off-by: Ry Jones <ry@linux.com>

* Disconnected from the gateway in fabcar query.js (hyperledger#190)

Signed-off-by: pratikpatil024 <pratikspatil024@gmail.com>

* FABG-935 GoSDK Fabcar sample (hyperledger#192)

Fabcar sample demonstrating the use of the new Gateway package in the Go SDK

Signed-off-by: andrew-coleman <andrew_coleman@uk.ibm.com>

Co-authored-by: Tiffany Harris <tiffany.harris@ibm.com>
Co-authored-by: Ry Jones <ry@linux.com>
Co-authored-by: Pratik Patil <pratikspatil024@gmail.com>
Co-authored-by: Andrew Coleman <andrew_coleman@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants