Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FAB-17680] Support removing an org #992

Merged
merged 1 commit into from
Apr 6, 2020
Merged

Conversation

wuxuer
Copy link
Contributor

@wuxuer wuxuer commented Apr 3, 2020

Removing an organization from a consortium, application, and orderer.

Signed-off-by: xu wu wuxu1103@163.com

Type of change

  • New feature

Description

Additional details

Related issues

https://jira.hyperledger.org/browse/FAB-17680

@wuxuer wuxuer requested a review from a team as a code owner April 3, 2020 14:11
@wuxuer
Copy link
Contributor Author

wuxuer commented Apr 3, 2020

While running basic checks, CI returned the following error message:

Checking with go vet
# github.com/hyperledger/fabric/pkg/config [github.com/hyperledger/fabric/pkg/config.test]
pkg/config/organization_test.go:101:3: unknown field 'ChannelID' in struct literal of type Channel
pkg/config/organization_test.go:133:3: unknown field 'ChannelID' in struct literal of type Channel

However, I failed to find any error about organization_test.go, and the CI I was running locally was error-free.
Can someone tell me any useful information about this error? Thanks very much.

@caod123
Copy link

caod123 commented Apr 3, 2020

@hellosmallstone channel ID was removed from the channel struct as part of #962 that was just merged, you can just remove it from your test

@ryjones
Copy link
Contributor

ryjones commented Apr 3, 2020

I think if you rebase to the tip of the branch, you'll see this

Removing an organization from a consortium, application, and orderer.

Signed-off-by: xu wu <wuxu1103@163.com>
@wuxuer
Copy link
Contributor Author

wuxuer commented Apr 4, 2020

@hellosmallstone channel ID was removed from the channel struct as part of #962 that was just merged, you can just remove it from your test

Thanks very much. I have removed "ChannelID" and all the checks have passed.

@wuxuer
Copy link
Contributor Author

wuxuer commented Apr 4, 2020

I think if you rebase to the tip of the branch, you'll see this

Based on your suggestions, I saw this error.
Thanks very much.

@caod123 caod123 merged commit d5a2fa8 into hyperledger:master Apr 6, 2020
@wuxuer wuxuer deleted the FAB-17680 branch April 7, 2020 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants