Support bootstrap using non docker container CLI #3552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows specifying a different CLI so the following is possible for instance: CONTAINER_CLI=podman ./bootsrap.sh -s Signed-off-by: Arnaud J Le Hors <lehors@us.ibm.com>
yacovm
reviewed
Jul 28, 2022
|
I could but that's not the choice that was made in fabric-samples because sometimes we need to be able to differentiate which cli is being used, such as in: So it makes sense to be consistent. |
yacovm
approved these changes
Jul 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows specifying a different CLI so the following is
possible for instance:
CONTAINER_CLI=podman ./bootsrap.sh -s
Signed-off-by: Arnaud J Le Hors lehors@us.ibm.com
Type of change
Description
Additional details
Related issues