[FAB-17177] Config block shouldn't verify itself in block replication #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yacovm
requested review from
ale-linux,
binhn,
C0rWin,
christo4ferris,
denyeart,
guoger,
jyellick,
kchristidis,
manish-sethi,
mastersingh24,
muralisrini and
sykesm
as code owners
yacovm
changed the title
C0rWin
previously approved these changes
Dec 3, 2019
The cluster replication verifies blocks by pulling them in batches, and performs hash chain verification + verifies the signatures of the last block in the chain. It uses the bundle stored in the global config structures, but in case it comes across a config block in the middle of the batch, it switches to use a bundle constructed from that config block. However, if the config block is the last block in the batch - it accidentally verifies it twice: - once with the config block before it (as expected) - once with the config block itself (which is unexpected). This change set simply adds a check to see if the last block in the batch is a config block, and if so - doesn't verify it if it was already verified. Change-Id: Id123c36e445a21b3081273ef0395aae759162818 Signed-off-by: yacovm <yacovm@il.ibm.com>
yacovm
force-pushed
the
configBlockDoubleVerifyIsBad
branch
from
7d42cee to
2bb4c29
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jyellick
approved these changes
Dec 3, 2019
C0rWin
approved these changes
Dec 3, 2019
cendhu
pushed a commit
to cendhu/fabric
that referenced
this pull request
Dec 11, 2019
…yperledger#355) The cluster replication verifies blocks by pulling them in batches, and performs hash chain verification + verifies the signatures of the last block in the chain. It uses the bundle stored in the global config structures, but in case it comes across a config block in the middle of the batch, it switches to use a bundle constructed from that config block. However, if the config block is the last block in the batch - it accidentally verifies it twice: - once with the config block before it (as expected) - once with the config block itself (which is unexpected). This change set simply adds a check to see if the last block in the batch is a config block, and if so - doesn't verify it if it was already verified. Change-Id: Id123c36e445a21b3081273ef0395aae759162818 Signed-off-by: yacovm <yacovm@il.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description and additional details
The cluster replication verifies blocks by pulling them in batches,
and performs hash chain verification + verifies the signatures of the last block in the chain.
It uses the bundle stored in the global config structures,
but in case it comes across a config block in the middle of the batch,
it switches to use a bundle constructed from that config block.
However, if the config block is the last block in the batch -
it accidentally verifies it twice:
This change set simply adds a check to see if the last block in the batch
is a config block, and if so - doesn't verify it if it was already verified.
Change-Id: Id123c36e445a21b3081273ef0395aae759162818
Signed-off-by: yacovm yacovm@il.ibm.com