[FAB-11334] Adds a function to purge a ledger's transient storage #2769
Conversation
jkneubuh
force-pushed
the
feature/unjoin-transient-store
branch
2 times, most recently
from
db72f29 to
daca3db
Compare
jkneubuh
force-pushed
the
feature/unjoin-transient-store
branch
from
daca3db to
666846e
Compare
| // Determine if the lock is currently held open. | ||
| func (f *FileLock) IsLocked() bool { | ||
| return f.db != nil | ||
| } | ||
|
|
There was a problem hiding this comment.
I won't over-emphasize this but just to take a note - as the introduction of this function now assumes (at this level of code) that this struct can be used by a more than one go routines, access to field f.db should be protected. Else, a caller can get a wrong result from this function.
However, we are using this struct in a very limited way and don't foresee any plan to use this function in a test with concurrent go-routines, I am fine leaving it as is; but appreciate if you want to fix this for cleanliness at this level of the code.
jkneubuh
force-pushed
the
feature/unjoin-transient-store
branch
3 times, most recently
from
b475cb8 to
09d21a2
Compare
This introduces a transientstore.Delete(ledgerID) routine to assist with the bookkeeping while unjoining a peer from a channel. Before removing the transient storage, the store is marked as UNDER_DELETION in a system leveldb, providing an opportunity to recover from a failed deletion at the next peer initialization. Signed-off-by: Josh Kneubuhl <jkneubuh@us.ibm.com>
jkneubuh
force-pushed
the
feature/unjoin-transient-store
branch
from
09d21a2 to
c1dc94e
Compare
|
OK. I think this one is a wrap. I agree we should look to find a wider grain / common lock to handle "peer is running" concurrently with CLI activities requiring the peer to be shut down. |
| defer lock.Unlock() | ||
| defer os.RemoveAll(lockPath) |
There was a problem hiding this comment.
I think that your intent was the following. The defers are executed in reverse order.
| defer lock.Unlock() | |
| defer os.RemoveAll(lockPath) | |
| defer func(){ | |
| lock.Unlock() | |
| os.RemoveAll(lockPath) | |
| }() |
… from a channel (hyperledger#2769) This change adds a Viper cobra.Command to unjoin the peer from a specified channel. Signed-off-by: Josh Kneubuhl <jkneubuh@us.ibm.com>
… from a channel (#2769) This change adds a Viper cobra.Command to unjoin the peer from a specified channel. Signed-off-by: Josh Kneubuhl <jkneubuh@us.ibm.com>
Type of change
Description
This introduces a transientstore.Delete(ledgerID) routine to assist with the bookkeeping while unjoining a peer from a channel. Before removing the transient storage, the store is marked as UNDER_DELETION in a system leveldb, providing an opportunity to recover from a failed deletion at the next peer initialization.
Signed-off-by: Josh Kneubuhl jkneubuh@us.ibm.com
Additional details
Related issues
Resolves #2786