Evict Transactions by sender from tail first #4327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyschulte
changed the title
garyschulte
force-pushed
the
feature/tx-evict-only-from-tail
branch
6 times, most recently
from
d73f44a to
5b885bf
Compare
garyschulte
force-pushed
the
feature/tx-evict-only-from-tail
branch
from
5b885bf to
dcc239e
Compare
garyschulte
added a commit
to garyschulte/besu
that referenced
this pull request
Sep 1, 2022
Signed-off-by: garyschulte <garyschulte@gmail.com>
2 tasks
jflo
approved these changes
Sep 1, 2022
…t price Signed-off-by: garyschulte <garyschulte@gmail.com>
…n sequence id (to better prevent collisions for same gas price and sequence id) Signed-off-by: garyschulte <garyschulte@gmail.com>
use default systemclock instead of fixed change multi-type txpool tests to use different senders to assert the desired eviction behavior Signed-off-by: garyschulte <garyschulte@gmail.com>
garyschulte
force-pushed
the
feature/tx-evict-only-from-tail
branch
from
dcc239e to
aa3f2e5
Compare
garyschulte
added a commit
to garyschulte/besu
that referenced
this pull request
Sep 1, 2022
Signed-off-by: garyschulte <garyschulte@gmail.com>
garyschulte
added a commit
to garyschulte/besu
that referenced
this pull request
Sep 7, 2022
* evict transactions from tail of senderAndNonce rather than just lowest price * make pendingTransactions secondary sort based on timestamp rather than sequence id (to better prevent collisions for same gas price and sequence id) Signed-off-by: garyschulte <garyschulte@gmail.com>
garyschulte
added a commit
to garyschulte/besu
that referenced
this pull request
Sep 7, 2022
* evict transactions from tail of senderAndNonce rather than just lowest price * make pendingTransactions secondary sort based on timestamp rather than sequence id (to better prevent collisions for same gas price and sequence id) Signed-off-by: garyschulte <garyschulte@gmail.com>
garyschulte
added a commit
to garyschulte/besu
that referenced
this pull request
Sep 7, 2022
* evict transactions from tail of senderAndNonce rather than just lowest price * make pendingTransactions secondary sort based on timestamp rather than sequence id (to better prevent collisions for same gas price and sequence id) Signed-off-by: garyschulte <garyschulte@gmail.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
* evict transactions from tail of senderAndNonce rather than just lowest price * make pendingTransactions secondary sort based on timestamp rather than sequence id (to better prevent collisions for same gas price and sequence id) Signed-off-by: garyschulte <garyschulte@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Ensure when besu evicts transactions by sender, that future nonces are evicted first
Fixed Issue(s)
related to protocol-misc 629
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog