Make use of NLL to clean up handshaking logic #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nox
force-pushed
the
nll
branch
2 times, most recently
from
3a85df2 to
c2f930e
Compare
hawkw
approved these changes
Jan 19, 2022
There was a problem hiding this comment.
yup, this definitely looks much nicer than the pre-NLL code! after reading over this code, there doesn't appear to be any change in behavior, so this looks great to me!
i left a couple small suggestions we might want to address while we're cleaning this up, but they're not really blockers.
nox
force-pushed
the
nll
branch
2 times, most recently
from
5a5b350 to
8a9ae69
Compare
seanmonstar
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.