Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix html anchor parsing wrong in some docs #47

Merged
merged 2 commits into from
Dec 5, 2015
Merged

Conversation

asherascout
Copy link
Contributor

I made some code changes as you said.
Please check it.

Thank you.

@hynek
Copy link
Owner

hynek commented Dec 5, 2015

dicts are unsorted, so you’ll have to convert both sides of the assert into a set()

BTW, no need to open another PR, you can push more commits to this branch.

Just make sure you ping the issue because repo owners are not notified about new commits

Some path parse from objects.inv like the one in alembic's would be
'index.html#document-api/ddl#alembic.ddl.mysql.MySQLChangeColumn'.
As you see, there is more than one '#' in this path, and it cannot
be recognised correctly.
That may be the inv file's error. This commit replace the path with
head and tail of the original. It can fix this issue.
@asherascout
Copy link
Contributor Author

Sorry about these mistakes...
But I still don't know why it failed in Python: 2.7 TOXENV=flake8.

@hynek
Copy link
Owner

hynek commented Dec 5, 2015

Because "py:method": and "std:option": are indented differently. Joining lines 42 and 43 should be enough to make it pass.

@asherascout
Copy link
Contributor Author

WOW, It works!
The indent in python really confused me. Still a lot to learn.
My first github commit done! thanks to you! ^o^/

hynek added a commit that referenced this pull request Dec 5, 2015
Fix html anchor parsing wrong in some docs
@hynek hynek merged commit 0601145 into hynek:master Dec 5, 2015
@hynek
Copy link
Owner

hynek commented Dec 5, 2015

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants