Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colorful NixOS logo #311

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Colorful NixOS logo #311

merged 3 commits into from
Oct 23, 2024

Conversation

Til7701
Copy link
Contributor

@Til7701 Til7701 commented Jun 18, 2024

Description

Adding another option for NixOS to set all colors separately.

Screenshots

image

@luna-1024
Copy link
Contributor

Hey there!

I am a NixOS user as well and also want to be able to color the logo like you have proposed. I am taking the time to work on a generalized approach that would improve many distros' logos. It might make sense to go with my approach instead.


Regardless of what I have been working on, here's some feedback on your PR:

When adding a logo, only modify neofetch. The auto-generated code in hyfetch/distros and docs will be generated in the release process. See this recent PR as an example. Note that it modifies the docs but probably did not need to.

As it stands, there are generally only small and old variants of logos. We should decide if the documentation should document colorful variants of logo(s) as well.


And here's my thoughts on logo coloring:

I think it would be great if more colorful "segmented" logos would be easily accessible by the user. If we add a colored version as a new entry, the user would have to look into the options/manual/source to discover it exists. Perhaps only a fraction of users will do that, as many may not even consider the possibility variants exist. If we can get the colorful logo to users by default, it would be awesome to have a lot more colorful NixOS (and other distro) segmented logos common in screenshots out in the wild!

The configuration UI could be improved as well since the randomized rolling system would take a lot of rolls to get the rainbow colors in the correct order.

For now, I have already have a small-ish change prepared for backwards compatibility for direct modifications to a logo where nothing is changed but having more colorable areas/segments. If it is accepted, we could directly modify the NixOS logo as you have it after that code is in. That results in functional parity with your change, and should be achievable fairly quickly. Then NixOS users setting up their hyfetch would have 6 separately colored lambdas by default. (As well for any other distros we improve the coloring)

I would like to hear your thoughts on this approach! As well from @hykilpikonna

@Til7701
Copy link
Contributor Author

Til7701 commented Jul 20, 2024

I like the idea of a general approach to the problem. However, I do not have enough experience with python to help you with it.

I can remove the changes outside of neofetch, if hykilpikonna wants me to. I have been using my fork for a while. That's why they are there.

@luna-1024
Copy link
Contributor

Hey, thanks for responding!

It has been a while since my last comment here. I intended to submit a more detailed proposal for the feature after I had my outstanding bug fix PR reviewed, as to not leave too much on the maintainer's plate. There has since been a slowdown in the maintenance activity in this project (it is fine to take a break), as well as a rewrite of the whole hyfetch program in Rust being prepared that is probably close to being accepted. Thus I have held off on moving forward, but hopefully soon will be a good time.

If my proposal is accepted, I am prepared to support it by carrying out the implementation (likely in Rust). I am invested to see it through, though help certainly could get it more smoothly and quickly completed.

@luna-1024 luna-1024 mentioned this pull request Jul 26, 2024
6 tasks
@hykilpikonna hykilpikonna merged commit 87e6092 into hykilpikonna:master Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants