Skip to content

Hyfetch assumes config is writeable when adding 'pride animation shown' flag #136

Closed
@Aleksanaa

Description

@Aleksanaa

Describe the bug

Hyfetch now displays an animation at the first start, and tries to add a flag to the config saying that it is shown.

config.pride_month_shown.append(now.year)

It may appear to be reasonable, but what if you are using home-manager? The config is just a symlink pointing to the read-only Nix store. If you tries to write to it, you'll fail, and if you choose to override it, home-manager will fail to deploy the next time.

  • Does this issue still occur in the master branch? (Required)

Expected behavior

So just don't touch the config. If the config already exists, leave it there. And if we want to persist any state, just place it in xdg cache.

Additional context

Add any other context about the problem here.

Activity

added a commit that references this issue on Jun 15, 2023
hykilpikonna

hykilpikonna commented on Jun 15, 2023

@hykilpikonna
Owner

Thanks for reporting the issue! It will create a file $XDG_CACHE_HOME/hyfetch/animation-displayed-{year} instead of writing the config from now on

added a commit that references this issue on Apr 30, 2024
3edca64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Hyfetch assumes config is writeable when adding 'pride animation shown' flag · Issue #136 · hykilpikonna/hyfetch