Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document #180

Merged
merged 2 commits into from
Mar 3, 2021
Merged

Document #180

merged 2 commits into from
Mar 3, 2021

Conversation

buzacott
Copy link

@buzacott buzacott commented Mar 2, 2021

All Submissions:

  • Have you followed the guidelines in our CONTRIBUTING document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Closes

Closes #166 properly

Types of changes

  • Bug fix (non-breaking change which fixes an issue. List the bug ID if applicable)

This change properly fixes 166 and should allow people to install directly from GitHub.

The workflow needs to be manually triggered on PRs with the /document comment. This will add any changes in documentation, as well as add any updates to RcppExport files.

An example of it in action can be seen here: buzacott#8

In future we can consider if we want this to happen automatically after the decision has been made to merge PRs. Otherwise we will have to remember to comment /document to keep the documentation up to date and to avoid breaking GitHub installs.

I think this PR should be merged, then we can run it on the HBV PR to get the proper files in the repo.

@josephguillaume
Copy link
Collaborator

/document

@josephguillaume josephguillaume merged commit 33bb1ec into hydromad:master Mar 3, 2021
@buzacott buzacott deleted the document branch March 3, 2021 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installing from master currently fails
2 participants