fixed bug in read/write gpio code, and cleaned up some comments #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #569 +/- ##
==========================================
- Coverage 51.49% 51.43% -0.07%
==========================================
Files 162 162
Lines 15536 15545 +9
==========================================
- Hits 8001 7996 -5
- Misses 7133 7140 +7
- Partials 402 409 +7
Continue to review full report at Codecov.
|
deadprogram
reviewed
Jun 21, 2018
drivers/i2c/mcp23017_driver_test.go
Outdated
| @@ -11,18 +11,18 @@ import ( | |||
| "gobot.io/x/gobot/gobottest" | |||
| ) | |||
|
|
|||
| var _ gobot.Driver = (*MCP23017Driver)(nil) | |||
There was a problem hiding this comment.
I'd leave this line alone since it is actually a test that ensures that the driver supports the gobot.Driver interface, or else it will not compile.
There was a problem hiding this comment.
Thank you for reviewing the changes, I've added that line back to the test file.
|
Thanks @ulisesflynn now merging. |
gen2thomas
added a commit
to gen2thomas/gobot
that referenced
this pull request
Mar 19, 2022
deadprogram
pushed a commit
that referenced
this pull request
Apr 8, 2022
gen2thomas
added a commit
to gen2thomas/gobot
that referenced
this pull request
Apr 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes bugs found in issue: #568 as well as some general cleanup of the library.