Fixed the issue that bound PVC was not filtered #1556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
242
to
249
|
|
||
| //Filter the bound pvc | ||
| if pvc.Status.Phase == "Bound" { | ||
| continue | ||
| } | ||
|
|
There was a problem hiding this comment.
this change may cause confusion of this func getAssociatedVolumes, the filter logic may happen where these associated volumes are used
There was a problem hiding this comment.
This function is currently only responsible for calculating the capacity when creating a volume. I think it might be more convenient to use if we change its name.
There was a problem hiding this comment.
I modified the code.According to analysis, only the vol passed when creating vol for the first time is a virtual one without config parameters. If it is a migration or expansion scenario, it will not be affected.
FloatXD
added
Full test
Signed-off-by: peng9808 <peng.lai@daocloud.io>
peng9808
added
Full test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
#1554
Special notes for your reviewer:
NONE
Does this PR introduce a user-facing change?
NONE