Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated constants with enums #229

Merged
merged 2 commits into from
Nov 3, 2024
Merged

Replace deprecated constants with enums #229

merged 2 commits into from
Nov 3, 2024

Conversation

hugovk
Copy link
Owner

@hugovk hugovk commented Oct 30, 2024

https://github.com/prettytable/prettytable/releases/tag/3.12.0
prettytable/prettytable#329

Fixes:

tests/test_norwegianblue.py::TestNorwegianBlue::test_norwegianblue_formats[markdown0]
  /Users/hugo/github/norwegianblue/src/norwegianblue/__init__.py:230: DeprecationWarning: the 'MARKDOWN' constant is deprecated, use the 'TableStyle' enum instead
    from prettytable import MARKDOWN, SINGLE_BORDER, PrettyTable

tests/test_norwegianblue.py::TestNorwegianBlue::test_norwegianblue_formats[markdown0]
  /Users/hugo/github/norwegianblue/src/norwegianblue/__init__.py:230: DeprecationWarning: the 'SINGLE_BORDER' constant is deprecated, use the 'TableStyle' enum instead
    from prettytable import MARKDOWN, SINGLE_BORDER, PrettyTable

@hugovk hugovk added the changelog: Fixed For any bug fixes label Oct 30, 2024
@hugovk hugovk merged commit 7652bba into main Nov 3, 2024
47 checks passed
@hugovk hugovk deleted the fix-deprecations branch November 3, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
changelog: Fixed For any bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hugovk