-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix DS for peft ref_model in ppo trainer #309
Conversation
peft ref_model is got by calling `disable_adapter` method, e.g. , ``` with self.accelerator.unwrap_model(self.model).pretrained_model.disable_adapter(): ref_logprobs, _, _, _ = self.batched_forward_pass(self.model, queries, responses, model_inputs) ```
The documentation is not available anymore as the PR was closed or merged. |
Hi @halfrot |
sure and I just reproduced this error by running
here
and also error logs here
|
Awesome, can you confirm this fixes your issue? i.e. after that you can train correctly with DS + peft + int8? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for fixing the PEFT + DeepSpeed + int8 issue! Awesome contribution!
self.ref_model
can be None. peft ref_model is got by callingdisable_adapter
method, e.g. ,