corrects loss function for Self-play Preference Optimization hard label version #1615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelahzyuan
changed the title
angelahzyuan
changed the title
kashif
approved these changes
May 3, 2024
|
@angelahzyuan thank you for the fix! Can you kindly run the |
|
@angelahzyuan perhaps move the comment inside the |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
@kashif done |
kashif
reviewed
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects implementation mentioned in #1612. arxiv: https://arxiv.org/abs/2405.00675. This updates the loss function according to Equation (4.8) with$P(y_w > y_l) = 1$ and $P(y_l > y_w) = 0$ , and justified it in doc as the hard label version of the algorithm.
It should work well now for the first iteration. The reported 3 iterations' results were based on the soft label version.