Correct ppo_epochs usage #1480
Merged
Correct ppo_epochs usage #1480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The usage of ppo_epochs is incorrect here. In https://github.com/huggingface/trl/blob/8534f0edf8608ad6bcbea9beefae380fa60ded77/trl/trainer/ppo_config.py#L104C8-L104C58 the ppo_epochs was described as "Number of optimisation epochs per batch of samples". However, here it is used as the usual epoch number, in which you do one iteration over the training dataset.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
kashif
approved these changes
Apr 2, 2024
kashif
reviewed
Apr 2, 2024
kashif
approved these changes
Apr 2, 2024
lapp0
pushed a commit
to lapp0/trl
that referenced
this pull request
May 10, 2024
* Correct ppo_epochs usage The usage of ppo_epochs is incorrect here. In https://github.com/huggingface/trl/blob/8534f0edf8608ad6bcbea9beefae380fa60ded77/trl/trainer/ppo_config.py#L104C8-L104C58 the ppo_epochs was described as "Number of optimisation epochs per batch of samples". However, here it is used as the usual epoch number, in which you do one iteration over the training dataset. * Update ppo_trainer.mdx * Update docs/source/ppo_trainer.mdx --------- Co-authored-by: Kashif Rasul <kashif.rasul@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The usage of ppo_epochs is incorrect here.
In https://github.com/huggingface/trl/blob/8534f0edf8608ad6bcbea9beefae380fa60ded77/trl/trainer/ppo_config.py#L104C8-L104C58
the ppo_epochs was described as the "Number of optimisation epochs per batch of samples".
However, here it is used as the usual epoch number, in which you do one iteration over the training dataset.