Fixing tests. It seems master changed something in the warnings. #9483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to keep warning tests for now. Should be discarded if it becomes too hard to maintain.
|
I don't understand this: |
|
Would be nice to find what triggered this to be sure we didn't introduce a bug no? |
|
@patrickvonplaten I think we're good. It's this commit 79bbcc5 that triggered the extra warning. |
patrickvonplaten
approved these changes
Jan 10, 2021
guyrosin
pushed a commit
to guyrosin/transformers
that referenced
this pull request
Jan 15, 2021
…gingface#9483) Trying to keep warning tests for now. Should be discarded if it becomes too hard to maintain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Trying to keep warning tests for now. Should be discarded if it becomes
too hard to maintain.
60 started to trigger a new warning, saying that the input_ids length was longer than model max_length.
I'm not really sure which commit triggered this, but it did not occur in the original PR
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@patrickvonplaten
@LysandreJik
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors which may be interested in your PR.