Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed PreTrainedModel.from_pretrained(...) not passing cache_dir to PretrainedConfig.from_pretrained(...) #864

Closed
wants to merge 1 commit into from
Closed

Fixed PreTrainedModel.from_pretrained(...) not passing cache_dir to PretrainedConfig.from_pretrained(...) #864

wants to merge 1 commit into from

Conversation

mbugert
Copy link

@mbugert mbugert commented Jul 22, 2019

See #863

It's not a beautiful solution, but neither is the practice of modifying incoming parameters via pop. 🤷‍♂

@anlsh anlsh mentioned this pull request Jul 22, 2019
Merged
@thomwolf
Copy link
Member

Indeed thanks. We'll subsume this PR with #866 which add a few other stuff.

I agree with you on the pop pattern. We'll move away from this when the first one of these two events happens: (i) google stop open-sourcing interesting new models or (ii) google stop using python 2 internally ;)

@thomwolf thomwolf closed this Jul 23, 2019
@mbugert
Copy link
Author

mbugert commented Jul 23, 2019

Okay! 👍

PiercarloSlavazza pushed a commit to PiercarloSlavazza/transformers that referenced this pull request Feb 22, 2022
@Narsil
Fix invalid continuing subwrd prefix. (huggingface#864)
1054e24 
* Creating failing test for invalid continuing subwrd prefix.

* Test in rust + the associated fix.

* Clippy.

* Black.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbugert @thomwolf