Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean directory after script testing #6453

Merged
merged 2 commits into from
Aug 13, 2020
Merged

Clean directory after script testing #6453

merged 2 commits into from
Aug 13, 2020

Conversation

JetRunner
Copy link
Contributor

#6421 #6433

This PR cleans the directory after each script testing to prevent bugs like this.

@JetRunner JetRunner requested a review from LysandreJik August 13, 2020 07:10
@codecov
Copy link

codecov bot commented Aug 13, 2020 •
edited
Loading

Codecov Report

Merging #6453 into master will decrease coverage by 2.51%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6453      +/-   ##
==========================================
- Coverage   79.89%   77.37%   -2.52%     
==========================================
  Files         153      153              
  Lines       27902    27902              
==========================================
- Hits        22291    21588     -703     
- Misses       5611     6314     +703
Impacted Files Coverage Δ
src/transformers/optimization.py 25.55% <0.00%> (-70.00%) ⬇️
src/transformers/modeling_tf_distilbert.py 34.11% <0.00%> (-63.30%) ⬇️
src/transformers/pipelines.py 26.98% <0.00%> (-52.81%) ⬇️
src/transformers/optimization_tf.py 33.33% <0.00%> (-24.33%) ⬇️
src/transformers/modeling_tf_auto.py 48.79% <0.00%> (-18.08%) ⬇️
src/transformers/modeling_auto.py 64.16% <0.00%> (-14.46%) ⬇️
src/transformers/data/processors/squad.py 13.76% <0.00%> (-14.38%) ⬇️
src/transformers/modeling_tf_gpt2.py 65.68% <0.00%> (-6.16%) ⬇️
src/transformers/modelcard.py 82.71% <0.00%> (-2.47%) ⬇️
src/transformers/modeling_distilbert.py 96.19% <0.00%> (-1.64%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ffea5c...05950f1. Read the comment docs.

@JetRunner
Copy link
Contributor Author

JetRunner commented Aug 13, 2020 •
edited
Loading

I think cleaning the output dir seems to be a better solution than modifying output_dir, since people may still copy those output_dir in the future. What do you think? @LysandreJik

@JetRunner JetRunner requested a review from sgugger August 13, 2020 11:55
sgugger
sgugger approved these changes Aug 13, 2020
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@JetRunner JetRunner merged commit 7bc0056 into master Aug 13, 2020
@JetRunner JetRunner deleted the clean_test_dir branch August 13, 2020 16:34
@JetRunner JetRunner mentioned this pull request Aug 13, 2020
Closed
fabiocapsouza added a commit to fabiocapsouza/transformers that referenced this pull request Nov 15, 2020
@fabiocapsouza
Revert "Clean directory after script testing (huggingface#6453)"
add5e4d 
This reverts commit 243e2e8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

@LysandreJik LysandreJik Awaiting requested review from LysandreJik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JetRunner @sgugger