[tokenizers] Updates data processors, docstring, examples and model cards to the new API #5308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5308 +/- ##
==========================================
- Coverage 79.30% 77.20% -2.11%
==========================================
Files 138 138
Lines 24283 24285 +2
==========================================
- Hits 19258 18749 -509
- Misses 5025 5536 +511
Continue to review full report at Codecov.
|
|
@sshleifer @patrickvonplaten and @yjernite I updated your examples (seq2seq and eli5). Maybe you want to check it. |
lgtm! |
sshleifer
approved these changes
Jun 26, 2020
| @@ -41,12 +41,12 @@ def encode_file( | |||
| assert lns, f"found empty file at {data_path}" | |||
| examples = [] | |||
| for text in tqdm(lns, desc=f"Tokenizing {data_path.name}"): | |||
| tokenized = tokenizer.batch_encode_plus( | |||
| tokenized = tokenizer( | |||
jplu
pushed a commit
to jplu/transformers
that referenced
this pull request
Jun 29, 2020
…ards to the new API (huggingface#5308) * remove references to old API in docstring - update data processors * style * fix tests - better type checking error messages * better type checking * include awesome fix by @LysandreJik for huggingface#5310 * updated doc and examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the data-processors to the new recommended tokenizers' API instead of the old one.
Also update the docstrings, examples, and model-cards which were using the old API.
Supersede #5310
@sshleifer you have a couple of methods only your models use (bart and marian). I'm not sure about the consequences of updating those API so I'll let you update them. Here is the doc on the new tokenizer API if you need it: https://huggingface.co/transformers/master/preprocessing.html
Recommended updates:
__call__instead ofencode_plusandbatch_encode_pluspaddingandtruncationinstead ofmax_lengthonly andpad_to_max_length