Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Benchmarks] improve Example Plotter #5245

Conversation

patrickvonplaten
Copy link
Contributor

This PR make it possible to plot csv files that have "N/A" values.

@codecov
Copy link

codecov bot commented Jun 24, 2020

Codecov Report

Merging #5245 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5245      +/-   ##
==========================================
- Coverage   77.93%   77.92%   -0.01%     
==========================================
  Files         138      138              
  Lines       23860    23859       -1     
==========================================
- Hits        18595    18593       -2     
- Misses       5265     5266       +1     
Impacted Files Coverage Δ
src/transformers/benchmark/benchmark_args_utils.py 89.13% <ø> (-0.24%) ⬇️
src/transformers/modeling_tf_utils.py 86.00% <0.00%> (-0.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fe09ce...882b09d. Read the comment docs.

@patrickvonplaten patrickvonplaten merged commit 79a82cc into huggingface:master Jun 26, 2020
jplu pushed a commit to jplu/transformers that referenced this pull request Jun 29, 2020
* improve plotting

* better labels

* fix time plot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant