Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[style] add pandas to setup.cfg #5093

Merged
merged 1 commit into from
Jun 17, 2020
Merged

Conversation

sshleifer
Copy link
Contributor

Need to add pandas to setup.cfg. Otherwise, for people that have pandas installed locally isort tries to change eli5_utils.py everytime.

@codecov
Copy link

codecov bot commented Jun 17, 2020

Codecov Report

Merging #5093 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5093   +/-   ##
=======================================
  Coverage   77.28%   77.28%           
=======================================
  Files         133      133           
  Lines       22134    22134           
=======================================
  Hits        17107    17107           
  Misses       5027     5027           
Impacted Files Coverage Δ
src/transformers/modeling_tf_utils.py 87.26% <0.00%> (-0.16%) ⬇️
src/transformers/file_utils.py 75.40% <0.00%> (+0.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90c8338...eae4841. Read the comment docs.

@LysandreJik LysandreJik merged commit f1a3d03 into huggingface:master Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants