Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests] make cuda-only tests device-agnostic #35607

Merged
merged 6 commits into from
Jan 13, 2025
Merged

[tests] make cuda-only tests device-agnostic #35607

merged 6 commits into from
Jan 13, 2025

Conversation

faaany
Copy link
Contributor

@faaany faaany commented Jan 10, 2025

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@Rocketknight1
Copy link
Member

cc @ydshieh

@ydshieh
Copy link
Collaborator

ydshieh commented Jan 10, 2025

I will wait for this to be in a ready state, thanks!

@faaany faaany marked this pull request as ready for review January 13, 2025 05:21
ydshieh
ydshieh approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. What are the status of these tests in non-cuda accelerators ?

ArthurZucker
ArthurZucker approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks as always! 🤗

@ArthurZucker ArthurZucker merged commit 2fa876d into huggingface:main Jan 13, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArthurZucker ArthurZucker ArthurZucker approved these changes

@ydshieh ydshieh ydshieh approved these changes

@Rocketknight1 Rocketknight1 Awaiting requested review from Rocketknight1 Rocketknight1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@faaany @Rocketknight1 @ydshieh @ArthurZucker