Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix seamless TTS generate #34968

Merged
merged 13 commits into from
Dec 11, 2024
Merged

Conversation

ylacombe
Copy link
Contributor

Fix #34811

cc @ydshieh

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

(a comment would be appreciated even if just a few words 🙏 )

@ydshieh
Copy link
Collaborator

ydshieh commented Nov 27, 2024

let me check with the pipeline test - it's where I found this issue.

@ydshieh
Copy link
Collaborator

ydshieh commented Nov 27, 2024

it works now! Could you remove 2 lines below: # TODO and @run_test_using_subprocess before merge? Thanks

tests/pipelines/test_pipelines_text_to_audio.py

    # TODO: @ylacombe: `SeamlessM4TForTextToSpeech.generate` has issue with `generation_config`. See issue #34811
    @slow
    @require_torch
    @run_test_using_subprocess
    def test_medium_seamless_m4t_pt(self):

Copy link

@ruidazeng ruidazeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ylacombe
Copy link
Contributor Author

ylacombe commented Dec 10, 2024

I've removed the TODO!

@ydshieh
Copy link
Collaborator

ydshieh commented Dec 10, 2024

You can ignore

tests/models/seamless_m4t_v2/test_modeling_seamless_m4t_v2.py::SeamlessM4Tv2ModelWithSpeechInputTest::test_retain_grad_hidden_states_attentions

failing on multi-gpu runner.

@ylacombe ylacombe merged commit 6181c6b into huggingface:main Dec 11, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SeamlessM4TForTextToSpeech.generate not working if generation_config is passed
4 participants