Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: fix failures #34371

Merged
merged 1 commit into from
Oct 24, 2024
Merged

CI: fix failures #34371

merged 1 commit into from
Oct 24, 2024

Conversation

zucchini-nlp
Copy link
Member

What does this PR do?

Fixes failures caused by some previously merged PRs from our internal daily CI feedback. Some errors like eager_matched_sdpa were flaky, so no need to fix those.

InstructBLIP was failing because earlier we dispatched in "eager" by default and now we dispatch on "sdpa" for LLM

@ydshieh the new feature for CI feedback is perfect, and super easy to navigate and locate when the tests started failing. Thanks!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix and the feedback!

@zucchini-nlp zucchini-nlp merged commit b29c24f into huggingface:main Oct 24, 2024
17 checks passed
BernardZach pushed a commit to BernardZach/transformers that referenced this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants