Hi @htahboub, I don't think the proposed change is correct. The current logic condition is XOR i.e. it will fail if both or neither are specified, which is what we want to check for.

If you think the error message can be improved or clarified feel free to propose an update!

Hey! 🤗 Thanks for your contribution to the transformers library!

Before merging this pull request, slow tests CI should be triggered. To enable this:

• Add the run-slow label to the PR
• When your PR is ready for merge and all reviewers' comments have been addressed, push an empty commit with the command [run-slow] followed by a comma separated list of all the models to be tested, i.e. [run_slow] model_to_test_1, model_to_test_2
  • If the pull request affects a lot of models, put at most 10 models in the commit message
• A transformers maintainer will then approve the workflow to start the tests

(For maintainers) The documentation for slow tests CI on PRs is here.

Hey @amyeroberts. Sure, I thought that may be the case, in which case the error message is a little unclear. I have made changes to make that more explicit.

Thanks @amyeroberts, just made the change to the rest of the repo!

Hi @htahboub, there are some tests failing, can you please run make fix-copies?

Thanks @qubvel, just ran the command and pushed the changes.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.