Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MllamaProcessor] Update errors and API with multiple image #33715

Merged
merged 4 commits into from
Sep 26, 2024

Conversation

ArthurZucker
Copy link
Collaborator

@ArthurZucker ArthurZucker commented Sep 26, 2024

What does this PR do?

Fixes #33706 to support batches:

  • if one image or more per batch, padd and don't error our
  • if less than one image in one of the prompts, error out
  • if all text, don't error out
  • if images are not passed, but token is found, error out

@ArthurZucker ArthurZucker marked this pull request as ready for review September 26, 2024 09:38
@ArthurZucker ArthurZucker changed the title update error [MllamaProcessor] Update errors and API with multiple image Sep 26, 2024
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for providing a more complete test suite. Should this be in a patch?

@ArthurZucker ArthurZucker merged commit 46841d3 into main Sep 26, 2024
10 of 12 checks passed
@ArthurZucker ArthurZucker deleted the fix-mllama-batch branch September 26, 2024 14:33
ArthurZucker added a commit that referenced this pull request Sep 26, 2024
* update error

* update and add a test

* update

* update
BernardZach pushed a commit to BernardZach/transformers that referenced this pull request Dec 5, 2024
…gface#33715)

* update error

* update and add a test

* update

* update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

processing_mllama.py has a bug?
3 participants