[dependency] update pillow pins
#27409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
ArthurZucker
commented
Nov 10, 2023
ArthurZucker
changed the title
dependency] update pillow pins
amyeroberts
approved these changes
Nov 15, 2023
setup.py
Outdated
| @@ -95,7 +95,7 @@ | |||
| # 1. all dependencies should be listed here with their version requirements if any | |||
| # 2. once modified, run: `make deps_table_update` to update src/transformers/dependency_versions_table.py | |||
| _deps = [ | |||
| "Pillow<10.0.0", | |||
| "Pillow>=10.0.1,<=11.0", | |||
There was a problem hiding this comment.
I'll pin <=15.0, it's just to not allow whatever!
Thanks for the tips will run the slow model tests 😉
There was a problem hiding this comment.
- Vit
- Clip
- Detr (tests/models/detr/test_modeling_detr.py::DetrModelIntegrationTestsTimmBackbone::test_inference_panoptic_segmentation_head fails:
E - {'id': 1, 'label_id': 17, 'score': 0.994097, 'was_fused': False}
E ? ^
E
E + {'id': 1, 'label_id': 17, 'score': 0.994096, 'was_fused': False}Might be my arch rather than anything
- SAM
Which models would you think rely a lot on pillow version that I should test as well?
There was a problem hiding this comment.
I think that difference is definitely in the realm of acceptable!
All vision models rely on Pillow for their processing. I picked these models to cover different default resampling algos + popular models on different tasks. AFAICT - there's just bicubic, bilinear and nearest used for resizing settings and they've all been tested :)
…nto update-pillow
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Following, High Severity CVE, trying to update the pinned versions