Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add zh translation for installation #26084

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Conversation

yyLeaves
Copy link
Contributor

What does this PR do?

Who can review?

Documentation: @sgugger @stevhliu and @MKhalusova
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your translation! 🤗

For some reason, the second-level headings aren't being recognized so we're going to look into that. Once it gets resolved, we'll be free to merge!

@yyLeaves
Copy link
Contributor Author

Thanks for your translation! 🤗

For some reason, the second-level headings aren't being recognized so we're going to look into that. Once it gets resolved, we'll be free to merge!

Noted with thanks! @stevhliu

@stevhliu
Copy link
Member

stevhliu commented Oct 4, 2023

The issue should be resolved now, thanks again for your contribution and patience!

@stevhliu stevhliu merged commit 43bfd09 into huggingface:main Oct 4, 2023

## 使用conda安装

从conda`huggingface`频道安装:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra spacing may be desired here:

image

pip install transformers
```

若仅需CPU支持,可以使用单行命令方便地安装 🤗 Transformers 和深度学习库。例如,使用以下命令安装 🤗 Transformers 和PyTorch:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent spacing between CJK and ASCII characters.

Generally in web typesetting environments, it may be more comfortable to read by inserting spaces between those CJK and ASCII characters. Microsoft Word do it automatically, but web browsers don't.

There are several other instances of this issues in other part of the docs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your review @wfjsw, would you like to open a PR to fix this issue?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevhliu Sure! I'll do it later after finish reviewing other files. Meanwhile could you take a look at #26603?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent spacing between CJK and ASCII characters.

Generally in web typesetting environments, it may be more comfortable to read by inserting spaces between those CJK and ASCII characters. Microsoft Word do it automatically, but web browsers don't.

There are several other instances of this issues in other part of the docs.

The justification for the space inconsistency is that 🤗 Transformers seems like a proper noun so I followed the format in 快速上手. On a second review, neither 🤗 Transformers简介 nor 快速上手 section has a consistent translation format. Apart from the inconsistent space problem, they use a mix of Chinese and English punctuations (mostly English punctuations but Chinese punctuations would be more appropriate in my view). If possible, please also take into account these issues while fixing.

blbadger pushed a commit to blbadger/transformers that referenced this pull request Nov 8, 2023
* translate installation to zh

* fix translation typo
EduardoPach pushed a commit to EduardoPach/transformers that referenced this pull request Nov 18, 2023
* translate installation to zh

* fix translation typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants