Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix flax example tests #14643

Merged
merged 1 commit into from
Dec 6, 2021
Merged

fix flax example tests #14643

merged 1 commit into from
Dec 6, 2021

Conversation

patil-suraj
Copy link
Contributor

What does this PR do?

The conftest.py was missing from the flax examples directory. so the flax example tests are failing on master.
(cf here)

This PR adds the conftest.py file in the flax example directory.

sgugger
sgugger approved these changes Dec 6, 2021
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@patil-suraj patil-suraj merged commit cbe6026 into huggingface:master Dec 6, 2021
@patil-suraj patil-suraj deleted the fix-flax-ex-test branch December 6, 2021 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

@LysandreJik LysandreJik Awaiting requested review from LysandreJik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patil-suraj @sgugger