Add documentation examples for Tensor::i and Tensor::narrow methods
#2308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csicar
force-pushed
the
feature/tensor-index-docs
branch
from
77b5897 to
f28f0e5
Compare
LaurentMazare
approved these changes
Aug 10, 2024
|
Thanks, and sorry for the delay! |
|
No worries :) Thank you for merging |
EricLBuehler
pushed a commit
to EricLBuehler/candle
that referenced
this pull request
Aug 14, 2024
…ds (huggingface#2308) * Add documentation examples for `Tensor` methods * Apply fmt. * Cosmetic tweaks. --------- Co-authored-by: Laurent <laurent.mazare@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.i(a),.i((a,),.i((a, b)).narrow(dim, start, len)Open question
index_op_tuplemacro be kept? This would keep the verbosity low, but would mean that the doc comment is harder to read and looking at the source is harder. Both options are possible