Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add methods for adding/removing labels to GHIssue #461

Merged
merged 1 commit into from
Nov 6, 2018

Conversation

evenh
Copy link
Contributor

@evenh evenh commented Oct 1, 2018

This PR adds the functionality required to add/remove labels individually from a GHIssue (implements #456). One thing I haven't quite understood yet, is how/whether the data in this object can be refreshed (e.g. after adding a label, I want to inspect the labels present for a given issue).

I've never contributed to this project before, so please let me know if I have done something horribly wrong :-)

@evenh evenh force-pushed the ghissue-better-label-handling branch from 8c0ebe7 to 1c4b716 Compare October 1, 2018 21:29
@kohsuke kohsuke merged commit 1c4b716 into hub4j:master Nov 6, 2018
kohsuke added a commit that referenced this pull request Nov 6, 2018
@kohsuke
Copy link
Collaborator

kohsuke commented Nov 6, 2018

Thanks for the change.

I massaged the changes a bit, in particular, as a matter of personal preference, I don't like the kind of addLabel method that does multiple things like creating a label and silently tolerating missed parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants