fixed resource quota update issue when resource is updated to decrease #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdgetrf
requested review from
penggu,
m1093782566,
alfred-huangjian,
kevin-wangzefeng,
vinaykul,
XiaoningDing and
yingde-tang
pdgetrf
changed the title
added 2 commits
October 17, 2018 15:50
vinaykul
reviewed
Oct 19, 2018
| api.ResourceMemory: resource.MustParse("53Gi"), | ||
| api.ResourcePods: resource.MustParse("4"), | ||
| api.ResourceMemory: resource.MustParse("60Gi"), | ||
| api.ResourcePods: resource.MustParse("3"), |
There was a problem hiding this comment.
why does this change from 4 to 3?
vinaykul
reviewed
Oct 19, 2018
| Used: api.ResourceList{ | ||
| api.ResourceCPU: resource.MustParse("1100m"), | ||
| api.ResourceMemory: resource.MustParse("52Gi"), | ||
| api.ResourcePods: resource.MustParse("3"), |
There was a problem hiding this comment.
same here. this should be 4 isnt it?
vinaykul
reviewed
Oct 19, 2018
vinaykul
approved these changes
Oct 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also tested e2e on local environment