Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate to TypeScript (no runtime code changes) #410

Merged
merged 33 commits into from
May 25, 2020
Merged

chore: migrate to TypeScript (no runtime code changes) #410

merged 33 commits into from
May 25, 2020

Conversation

Shinigami92
Copy link
Contributor

@Shinigami92 Shinigami92 commented May 19, 2020 •
edited
Loading

Short description of what this resolves:

We want to create a stable code base in which errors can be identified quickly

Proposed changes:

  • Rewrite the project with typescript

closes #202
closes #277

@Shinigami92 Shinigami92 requested a review from thedaviddias May 19, 2020 14:22
@Shinigami92 Shinigami92 self-assigned this May 19, 2020
@Shinigami92
Copy link
Contributor Author

First experimental branch: https://github.com/htmlhint/HTMLHint/tree/chore/typescript-sub-1

I created an initial process workflow to leave our current rollup build unchanged

@Shinigami92
Copy link
Contributor Author

@thedaviddias I think I want to request a first review!

There are still errors and warnings, but from now on it might be that we need to change code!
So we may push this into a beta branch?

eslint is currently configured to allow warnings so the build can be triggered
The tests are green and I didn't touched the tests!

@Shinigami92 Shinigami92 changed the base branch from develop to beta May 21, 2020 16:55
@Shinigami92 Shinigami92 marked this pull request as ready for review May 21, 2020 16:56
@Shinigami92
Copy link
Contributor Author

For now I disabled some eslint rules and added some TODOs to resolve them later

This PR didn't touched runtime-code
This will be made in a next PR so we can track the changes in a better and more readable way

@Shinigami92
Copy link
Contributor Author

I have improved linting for the project so test folder is also linted with typescript checking and I improved linting with type-checking enabled.

thedaviddias
thedaviddias previously approved these changes May 25, 2020
View reviewed changes
.eslintignore Show resolved Hide resolved
.eslintrc.js Show resolved Hide resolved
build.js Outdated Show resolved Hide resolved
@Shinigami92 Shinigami92 changed the title chore: typescript chore: migrate to TypeScript (no runtime code changes) May 25, 2020
@Shinigami92 Shinigami92 requested a review from thedaviddias May 25, 2020 18:20
@Shinigami92 Shinigami92 merged commit bdd82b5 into beta May 25, 2020
@Shinigami92 Shinigami92 deleted the chore/typescript branch May 25, 2020 18:26
@thedaviddias
Copy link
Member

🎉 This PR is included in version 0.13.1-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@thedaviddias thedaviddias added the released on @beta The issue was released on the beta branch label May 30, 2020
@Shinigami92 Shinigami92 linked an issue May 31, 2020 that may be closed by this pull request
Move the code from bin into src #278
Closed
@thedaviddias
Copy link
Member

🎉 This PR is included in version 0.13.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thedaviddias thedaviddias thedaviddias approved these changes

Assignees

@Shinigami92 Shinigami92

Labels
released on @beta The issue was released on the beta branch
Projects
None yet
Milestone
No milestone
2 participants
@Shinigami92 @thedaviddias