Savedata: Update filelist on file erasure #16239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrydgard
approved these changes
Oct 16, 2022
Core/Dialog/SavedataParam.cpp
Outdated
| @@ -382,6 +385,40 @@ int SavedataParam::DeleteData(SceUtilitySavedataParam* param) { | |||
| ClearCaches(); | |||
| pspFileSystem.RemoveFile(filePath); | |||
|
|
|||
| // Update PARAM.SFO to remove the file, if it was ni the list. | |||
| @@ -382,6 +385,40 @@ int SavedataParam::DeleteData(SceUtilitySavedataParam* param) { | |||
| ClearCaches(); | |||
| pspFileSystem.RemoveFile(filePath); | |||
|
|
|||
| // Update PARAM.SFO to remove the file, if it was ni the list. | |||
| std::shared_ptr<ParamSFOData> sfoFile = LoadCachedSFO(sfoPath); | |||
There was a problem hiding this comment.
this could be a unique_ptr, right? (less overhead, though hardly matters here)
There was a problem hiding this comment.
LoadCachedSFO() returns a shared_ptr, because it returns a common pointer from a cache but you can clear its cache, so I just wanted to be safe from any crashes. For example, saving a file loads the SFO data, then clears the SFO cache (because it modifies things.)
It definitely can't be a unique_ptr, because the whole point of LoadCachedSFO() is to reuse the already loaded SFO data. Would not want it freed on each use.
-[Unknown]
There was a problem hiding this comment.
Oh right, yeah, should have gone looking inside LoadCachedSFO.
This is correct, ignore me.
Also stop reporting as "not coded."
unknownbrackets
force-pushed
the
savedata-erase
branch
from
62e88ec to
29e7a53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also stop reporting as "not coded."
Basically, this is the reason to use it over just deleting the file directly. Also, per some quick tests, SECURE vs non-SECURE doesn't seem to matter. Both happily delete a file created using WRITEDATASECURE or WRITEDATA, and both update the file list.
-[Unknown]