Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unmotivated check preventing texture ini creation on mobile. #15647

Merged
merged 5 commits into from
Jul 10, 2022

Conversation

hrydgard
Copy link
Owner

@hrydgard hrydgard commented Jul 4, 2022

Fixes #15644

Fixes #9989

@hrydgard hrydgard added the User Interface PPSSPP's own user interface / UX label Jul 4, 2022
@hrydgard hrydgard added this to the v1.13.0 milestone Jul 4, 2022
@LunaMoo
Copy link
Collaborator

LunaMoo commented Jul 4, 2022

I think this check was there because we couldn't "open" the file on mobile devices. If this didn't changed it probably needs to additionally show some notice that the file was created on mobiles. Otherwise there will be no indication that it worked(which on other platforms is by opening the file).

@hrydgard
Copy link
Owner Author

hrydgard commented Jul 5, 2022

That is a good point, will need to take that into account.

@hrydgard hrydgard force-pushed the allow-create-ini-on-mobile branch from b2cf9f2 to e82594e Compare July 10, 2022 16:50
@hrydgard hrydgard merged commit a831cab into master Jul 10, 2022
@hrydgard hrydgard deleted the allow-create-ini-on-mobile branch July 10, 2022 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
User Interface PPSSPP's own user interface / UX
Projects
None yet
2 participants