Execute_Prim: Add a smaller "inner interpreter" to speed long up sequences of PRIM commands #10658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o the runloop during long sequences of PRIM commands. Helps performance by a quite measurable 1-4% in several PRIM-heavy games.
hrydgard
force-pushed
the
inner-prim-interpreter
branch
from
318cbab to
ef3341e
Compare
|
Rebased on master. |
GPU/GPUCommon.cpp
Outdated
| @@ -1543,6 +1543,9 @@ void GPUCommon::Execute_Prim(u32 op, u32 diff) { | |||
| // PRIM commands with other commands. A special case that might be interesting is that game | |||
| // that changes culling mode between each prim, we could just change the triangle winding | |||
| // right here to still be able to join draw calls. | |||
| if (debugRecording_) | |||
There was a problem hiding this comment.
Might be nice to add || host->GPUDebuggingActive() here so that step prim works.
-[Unknown]
There was a problem hiding this comment.
I guess that depends on what you're debugging, it's kind of nice when stepping prim to see that the inner interpreter succeeds in running them in one pass, plus we don't flush after each prim when it does anyway so there's not much to see. But yeah, I guess in the usual case it's confusing to have it jump like that..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid going back to the runloop during long sequences of PRIM commands, and thus also avoiding all sorts of checking for the current framebuffer etc that are part of Execute_Prim.
Helps performance by a quite measurable 1-5% in several PRIM-heavy games.
Not particularly pretty, but effective.
This is also a first step towards fixing the performance of Earth Defense Force 2 and I believe possibly a couple of other games (Gundam?) which flip cull direction every few primitives.