Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix invalid WindowConfig schema, should match to the docs #1779

Merged
merged 1 commit into from
Mar 21, 2024
Merged

docs: fix invalid WindowConfig schema, should match to the docs #1779

merged 1 commit into from
Mar 21, 2024

Conversation

wookayin
Copy link
Contributor

@wookayin wookayin commented Dec 19, 2023 •
edited
Loading

Problem: cmp.WindowConfig was defined twice, and not consistent with docs |cmp.txt|.

Solution: Introduce cmp.CompletionWindowOptions and cmp.DocumentationWindowOptions.
Make fields of these two class consistent with |cmp-config.window.*|

@wookayin
docs: fix invalid WindowConfig schema, should match to the docs
82878cf 
Problem: `cmp.WindowConfig` was defined twice.

Solution: Introduce
  `cmp.CompletionWindowOptions` and `cmp.DocumentationWindowOptions`.
Make fields of these two class consistent with |cmp-config.window.*|
@hrsh7th
Copy link
Owner

hrsh7th commented Mar 21, 2024

perfect. thank you.

@hrsh7th hrsh7th merged commit 13451e7 into hrsh7th:main Mar 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wookayin @hrsh7th