-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Layer integration #83
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@kurisusnowdeng The checks are not passed |
FrankLeeeee
requested review from
FrankLeeeee
and removed request for
FrankLeeeee
December 21, 2021 08:43
kurisusnowdeng
force-pushed
the
main
branch
4 times, most recently
from
December 21, 2021 12:47
121adc0
to
062be2a
Compare
kurisusnowdeng
requested review from
FrankLeeeee
and removed request for
FrankLeeeee
December 21, 2021 12:48
kurisusnowdeng
requested review from
FrankLeeeee
and removed request for
FrankLeeeee
December 21, 2021 12:57
kurisusnowdeng
requested review from
FrankLeeeee
and removed request for
FrankLeeeee
December 21, 2021 13:33
FrankLeeeee
requested review from
FrankLeeeee
and removed request for
FrankLeeeee
December 22, 2021 05:33
kurisusnowdeng
requested review from
FrankLeeeee
and removed request for
FrankLeeeee
December 22, 2021 07:04
kurisusnowdeng
requested review from
FrankLeeeee
and removed request for
FrankLeeeee
December 23, 2021 14:08
kurisusnowdeng
requested review from
FrankLeeeee
and removed request for
FrankLeeeee
December 23, 2021 14:22
Hi @kurisusnowdeng , I have reviewed your code and some issues remain.
def lecun_uniform_():
# adapted from jax.nn.initializers
def initializer(tensor: Tensor, fan_in: int = None, fan_out: int = None):
assert fan_in is not None, 'Fan_in is not provided.'
var = 1.0 / fan_in
bound = math.sqrt(3 * var)
return nn.init.uniform_(tensor, -bound, bound)
return initializer
def lecun_normal_():
# adapted from jax.nn.initializers
def initializer(tensor: Tensor, fan_in: int = None, fan_out: int = None):
assert fan_in is not None, 'Fan_in is not provided.'
std = math.sqrt(1.0 / fan_in)
return nn.init.trunc_normal_(tensor, std=std / .87962566103423978)
return initializer
|
kurisusnowdeng
requested review from
FrankLeeeee
and removed request for
FrankLeeeee
December 24, 2021 06:15
kurisusnowdeng
requested review from
FrankLeeeee
and removed request for
FrankLeeeee
December 24, 2021 06:18
Fixed. Please check again. @FrankLeeeee |
kurisusnowdeng
requested review from
FrankLeeeee
and removed request for
FrankLeeeee
December 24, 2021 06:43
kurisusnowdeng
requested review from
FrankLeeeee
and removed request for
FrankLeeeee
December 26, 2021 17:00
kurisusnowdeng
requested review from
FrankLeeeee
and removed request for
FrankLeeeee
December 27, 2021 05:36
kurisusnowdeng
requested review from
FrankLeeeee
and removed request for
FrankLeeeee
December 27, 2021 05:40
FrankLeeeee
approved these changes
Dec 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
colossalai.nn
model_zoo
, with only one implementation for each model now.benchmark
, including cifar10 and imagenet100 training scriptsmodel_zoo