[zero] fix init bugs in zero context #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
1SAA
commented
Apr 7, 2022
1SAA
commented
- adapt model weight initialization for methods in Pytorch nn.init
feifeibear
reviewed
Apr 7, 2022
|
|
||
| def _pre_context_exec(self): | ||
| """ | ||
| The Callback function when entering the context | ||
| """ | ||
| self.logger = get_dist_logger("ZeroInitContext") | ||
|
|
||
| # substitute fan-in and fan-out calculation |
There was a problem hiding this comment.
Can you exhaust all possible functions？
_calculate_fan_in_and_fan_out and calc_fanin_fanout just two of them.
There was a problem hiding this comment.
It works for all init functions in nn.init and colossalai.nn.init.
feifeibear
approved these changes
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.